Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: stop using keypress #960

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

nielslyngsoe
Copy link
Member

Stop using keypress.

See: https://developer.mozilla.org/en-US/docs/Web/API/Element/keypress_event

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) November 18, 2024 14:31
Copy link

@nielslyngsoe nielslyngsoe merged commit 16eea44 into v1/contrib Nov 19, 2024
10 of 12 checks passed
@nielslyngsoe nielslyngsoe deleted the v1/feature/stop-using-keypress branch November 19, 2024 09:18
nielslyngsoe added a commit that referenced this pull request Nov 20, 2024
@nielslyngsoe nielslyngsoe added the enhancement New feature or request label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants